Discussion:
[Spice-devel] [PATCH spice-gtk] spice-channel: Add some comment to spice_channel_read
Frediano Ziglio
2018-11-21 11:24:17 UTC
Permalink
Document return value.

Signed-off-by: Frediano Ziglio <***@redhat.com>
---
src/spice-channel.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/src/spice-channel.c b/src/spice-channel.c
index 1486137e..602869e1 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1124,6 +1124,8 @@ static int spice_channel_read_sasl(SpiceChannel *channel, void *data, size_t len

/*
* Fill the 'data' buffer up with exactly 'len' bytes worth of data
+ * Returns 0 if connection was closed or unknown errors, <0 for error and
+ * length on success
*/
/* coroutine context */
static int spice_channel_read(SpiceChannel *channel, void *data, size_t length)
--
2.17.2
Christophe Fergeau
2018-11-22 14:32:20 UTC
Permalink
Post by Frediano Ziglio
Document return value.
---
src/spice-channel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index 1486137e..602869e1 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1124,6 +1124,8 @@ static int spice_channel_read_sasl(SpiceChannel *channel, void *data, size_t len
/*
* Fill the 'data' buffer up with exactly 'len' bytes worth of data
+ * Returns 0 if connection was closed or unknown errors, <0 for error and
"or on unknown errors" I think.

Acked-by: Christophe Fergeau <***@redhat.com>

Christophe
Post by Frediano Ziglio
+ * length on success
*/
/* coroutine context */
static int spice_channel_read(SpiceChannel *channel, void *data, size_t length)
--
2.17.2
_______________________________________________
Spice-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Loading...