Discussion:
[Spice-devel] [PATCH spice-gtk] spice-widget: Remove useless return statement
Frediano Ziglio
2018-11-29 17:42:08 UTC
Permalink
Signed-off-by: Frediano Ziglio <***@redhat.com>
---
src/spice-widget.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 312c640a..9bb42211 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2994,8 +2994,6 @@ static void channel_new(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *di
return;
}
#endif
-
- return;
}

static void channel_destroy(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *display)
--
2.17.2
Christophe Fergeau
2018-11-30 10:05:08 UTC
Permalink
Post by Frediano Ziglio
---
src/spice-widget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 312c640a..9bb42211 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2994,8 +2994,6 @@ static void channel_new(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *di
return;
}
#endif
-
- return;
}
static void channel_destroy(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *display)
--
2.17.2
_______________________________________________
Spice-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Eduardo Lima (Etrunko)
2018-12-03 21:22:48 UTC
Permalink
Post by Frediano Ziglio
---
src/spice-widget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 312c640a..9bb42211 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2994,8 +2994,6 @@ static void channel_new(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *di
return;
Isn't this one here useless as well?
Post by Frediano Ziglio
}
#endif
-
- return;
}
static void channel_destroy(SpiceSession *s, SpiceChannel *channel, SpiceDisplay *display)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
***@redhat.com
Frediano Ziglio
2018-12-05 09:17:16 UTC
Permalink
Post by Eduardo Lima (Etrunko)
Post by Frediano Ziglio
---
src/spice-widget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 312c640a..9bb42211 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2994,8 +2994,6 @@ static void channel_new(SpiceSession *s, SpiceChannel
*channel, SpiceDisplay *di
return;
Isn't this one here useless as well?
Didn't notice. Yes, currently useless too, I think is here in a sort
of coherent

if (this) {
handle this
return;
}
if (that) {
handle that
return;
}
....
Post by Eduardo Lima (Etrunko)
Post by Frediano Ziglio
}
#endif
-
- return;
}
static void channel_destroy(SpiceSession *s, SpiceChannel *channel,
SpiceDisplay *display)
Frediano

Loading...